chore: replace Karma with Playwright for browser tests#6031
chore: replace Karma with Playwright for browser tests#6031mostafaNazari702 wants to merge 6 commits into
Conversation
|
@mark-wiemer You did show some passion in opening a PR for that issue but i had the same passion. Sorry :) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6031 +/- ##
==========================================
+ Coverage 78.08% 78.88% +0.79%
==========================================
Files 63 63
Lines 4581 4546 -35
Branches 978 969 -9
==========================================
+ Hits 3577 3586 +9
+ Misses 1004 960 -44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Test failures are known issues, ref #5361 This one is on the review backlog :) it's a big backlog though! And absolutely no problem that you opened a PR for this, I'm often much happier reviewing PRs than I am trying to write code myself :) |
|
As Mostafa is now without laptop for a while, I'll validate and make the proposed changes and send back to you for re-review :) |
|
hm, checking lint failure, can't repro on local quite yet... I think this was a transient thing, I can't repro with the same Node version (22.22.3) on Windows :/ going to retrigger once the rest of the workflow finished |
|
Transient lint failure resolved, not going to track it... yet... but I'll link #5361 for funsies |
Yeah, it is - it's a failure to fully download the |
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
LGTM! Ready to ship whenever you are @mark-wiemer 🥳
PR Checklist
karmalibrary #5253status: accepting prsOverview
This is from a very old issue but i replaced the deprecated Karma setup with Playwright which ships its own bundled Chromium (no system Chrome required). The four browser suites (bdd/tdd/qunit/esm) now run in a real Chromium page via a small static server that serves the built mocha.js and a generated per-suite runner with results asserted via @playwright/test. npm run test-browser keeps the same clean=>build=>browser=>webpack-compat flow and CI installs the browser with npx playwright install --with-deps chromium.