Skip to content

Conversation

@thedevop
Copy link
Collaborator

@thedevop thedevop commented Mar 1, 2025

This includes changes:

  1. Address @dariopb's issue in Handle MessageExpiryInterval early enough for retained messages to honor it #442
  2. Only set pk.Expiry if pk.Properties.MessageExpiryInterval or MaximumMessageExpiryInterval is not zero-value
  3. Ensure outgoing pk.Properties.MessageExpiryInterval doesn't contain uint32(of negative value or zero-value) by setting a minimum of 1

@thedevop thedevop requested review from mochi-co and werbenhu March 1, 2025 03:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13600831491

Details

  • 25 of 25 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 98.63%

Totals Coverage Status
Change from base Build 13530155436: 0.004%
Covered Lines: 6192
Relevant Lines: 6278

💛 - Coveralls

Copy link
Collaborator

@mochi-co mochi-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you @thedevop

@mochi-co mochi-co merged commit b433215 into mochi-mqtt:main Mar 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants