Add support for calling input plane functions #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecodingwizard
commented
May 19, 2025
| @@ -13,6 +13,8 @@ import { | |||
| import { ClientType, ModalClientDefinition } from "../proto/modal_proto/api"; | |||
| import { profile, Profile } from "./config"; | |||
|
|
|||
| let modalAuthToken: string | undefined; | |||
There was a problem hiding this comment.
Note that the way we propagate auth tokens is a little different in Go vs. Typescript.
In Typescript (and Python), we propagate auth tokens via auth middleware / a grpc interceptor in client.ts.
In Go, we propagate auth tokens via context in function.go.
I'm open to changing Go's implementation to also propagate auth tokens via grpc interceptors in client.go for consistency if we think that's better, but it might be a bit trickier since Go is multithreaded? Regardless, we can always change our minds later.
thecodingwizard
force-pushed
the
nathan/inputplane
branch
2 times, most recently
from
0601472 to
52b14c5
Compare
thecodingwizard
force-pushed
the
nathan/inputplane
branch
from
52b14c5 to
bb7b679
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
libmodalsupport for calling input plane functions. This requires a few changes:ModalClientStubs pointing to different server URLs.x-modal-auth-tokenfromFunctionGetto the input plane RPCs.We will need to add support for retrying internal failures next.
Note that this PR cannot be merged until we enable input plane functions in production; otherwise, the tests will fail.