Report non-function Image build failures better #3172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaskom
force-pushed
the
michael/2025-05-20-better-image-build-failure
branch
from
969628f to
640d6e2
Compare
mwaskom
commented
May 27, 2025
| f"RUN {requirements_prefix}{_get_modal_requirements_command(builder_version)}", | ||
| ]) | ||
| if "2024.10" >= builder_version > "2023.12": | ||
| modal_requirements_commands.extend( |
There was a problem hiding this comment.
Looks like this pulled in some unrelated ruff changes...
|
@ehdr suggested on Slack that the error message could include a link to app logs which is a nice idea — but I don't think we have immediate access to that URL without adding more global state to the Resolver, so will have to punt on it for now. |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When Image builds fail, we try to print the
result.exception. Unless the failing step is a.run_function, this will be empty, so we print an unhelpful message likeThis PR handles the empty exception case better, directing the user to the build logs.
In the case where output is not enabled, we add a hint suggesting
modal.enable_output. Otherwise there won't be any obvious "build logs" for the user to refer to.This is still a little unhelpful (i.e., in the case where the build failed without output enabled, you need to run the build again, and that might take a while). I think we can potentially capture more failure information from the worker and propagate it back to the client. But it will take some more changes.
Checklists
Compatibility checklist
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.