Skip to content

Fix comment on workdir (very confusing) #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2025
Merged

Fix comment on workdir (very confusing) #3181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c5d59c
Fix comment on workdir (very confusing)
ekzhang May 24, 2025
1c434ff
Update api.proto
ekzhang May 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions modal_proto/api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1945,13 +1945,21 @@ message ImageJoinStreamingResponse {
message ImageMetadata {
// The output of `python -VV. Not set if missing
optional string python_version_info = 1;

// Installed python packages, as listed by by `pip list`.
// package name -> version. Empty if missing
map<string, string> python_packages = 2;
// The work directory of the image, defaulting to "/". Not set if missing

// The working directory of the image, defaulting to "/". Not set if missing.
//
// Note that this is NOT the actual working directory of the image, especially
// for runner tasks. Please see `ImageManifest.workdir` instead. This field
// should not be used in any future code.
optional string workdir = 3;
// The image's libc version

// The version of glibc in this image, if any.
optional string libc_version_info = 4;

// The builder version for/with which the image was created.
optional string image_builder_version = 5;
}
Expand Down
Loading