update deprecations #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhang-lucy
force-pushed
the
zhang-lucy/update-deprecations
branch
from
07951ff to
1a2220e
Compare
charlesfrye
reviewed
May 9, 2025
|
Thanks for fixing these deprecations! Would be cool to run the CI in such a way that the deprecation warnings are surfaced as errors. A good pattern for that would also be useful across all of our external example repos. |
zhang-lucy
commented
May 9, 2025
zhang-lucy
commented
May 9, 2025
|
lgtm, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still need to add back in the volumes