[draft][dnm] add script to find all modal files and check for deprecations #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhang-lucy
force-pushed
the
zhang-lucy/deprecations-ci
branch
from
14e7e70 to
dd0676f
Compare
zhang-lucy
force-pushed
the
zhang-lucy/deprecations-ci
branch
from
dd0676f to
db789c2
Compare
zhang-lucy
changed the title
charlesfrye
reviewed
May 9, 2025
| try: | ||
| with open(path, "r", encoding="utf-8") as f: | ||
| content = f.read() | ||
| return "@modal." in content or "modal.App()" in content |
| - name: Run ${{ matrix.example }} with modal | ||
| run: | | ||
| set -o pipefail | ||
| modal serve ${{ matrix.example }} 2>&1 | tee output.log |
There was a problem hiding this comment.
How do we know serve is the right command?
| set -o pipefail | ||
| modal serve ${{ matrix.example }} 2>&1 | tee output.log | ||
|
|
||
| - name: Check for deprecation warnings |
There was a problem hiding this comment.
Could we maybe just add a step like this after the existing CI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.