Add namespace and improve ProgressToken null handling #388
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added namespace declaration for
EverythingServer
and improvedProgressToken
null handling to enhance code organization and prevent potential null reference issues.Motivation and Context
SubscriptionMessageSender
class was missing a namespace declaration, which could lead to organization and accessibility issues.ProgressToken.ToString()
method was returning null in certain cases, which could cause null reference exceptions in consuming code. This change ensures consistent behavior by returning an empty string instead.How Has This Been Tested?
ProgressToken.ToString()
with various input types (string, long, and null) to ensure proper string conversionBreaking Changes
No breaking changes. The modifications are backward compatible:
Types of changes
Checklist
Additional context
The changes focus on improving code quality and safety:
ProgressToken.ToString()
follows the principle of least surprise and prevents null reference exceptions