Make enums serialize as strings if using the reflection-based serializer. #473
+46
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiriktsarpalis
force-pushed
the
reflection-use-string-enums
branch
from
b152524 to
b51df8a
Compare
eiriktsarpalis
force-pushed
the
reflection-use-string-enums
branch
from
b51df8a to
b2d6481
Compare
Will these changes to M.E.AI have any impact on users of the MCP SDK independently of the change in the PR? And does this mean we'd be inconsistent with using M.E.AI directly if we don't take this PR?
Can we somehow flip the default for the purposes of the MCP SDK? Could we make it an error either at build time or run time not to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While triaging #460 it occurred to me that Microsoft.Extensions.AI is enabling string-based enum serialization only when reflection-based serialization is turned on. This PR enables that behavior for MCP as well, however I'm not sure if it should be merged: it does introduce inconsistency between the reflection and source gen worlds after all.