Don't conflate request and response IDs in Streamable HTTP transports #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that's well described by #464 where the both the server and client Streamable HTTP transports improperly closed Streamable HTTP SSE response body streams early when it observed a server-to-client JsonRpcRequest, like a sampling request, with a message ID matching the ongoing client-to-server JsonRpcRequest.
This PR updates the server and client Streamable HTTP transports to only close the SSE response body stream when they observe a JsonRpcResponse or JsonRpcError with a matching ID.
Thanks @mkeeley-tricentis for the excellent issue that pointed directly to the problematic server-side code.