feat: HTTP Header Standardization for method and name#907
Open
guglielmo-san wants to merge 11 commits intomainfrom
Open
feat: HTTP Header Standardization for method and name#907guglielmo-san wants to merge 11 commits intomainfrom
guglielmo-san wants to merge 11 commits intomainfrom
Conversation
| req.Header.Set(methodHeader, "wrong-method") | ||
| } | ||
| resp, err := http.DefaultTransport.RoundTrip(req) | ||
| if err == nil && req.Header.Get(methodHeader) == "wrong-method" { |
Contributor
There was a problem hiding this comment.
Could you explain why do we need to capture anything? Doesn't the error from CallTool contain all necessary details?
Contributor
Author
There was a problem hiding this comment.
The issue was that chackResponse in streamableClientConn was only extracting the http.StatusCode from the error returned by the server and nothing else. I improved it to extract the jsonrpc error body and include it in the client Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements SEP-2243 (https://modelcontextprotocol.io/seps/2243-http-standardization) (HTTP Header Standardization) for Mcp-Method and Mcp-Name standard headers (x-mcp-param custom headers will be covvered in separate PR).
Fixes #905