Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): maintain order when changing values #206

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

markacianfrani
Copy link
Contributor

Motivation and Context

Resolves #205

How Has This Been Tested?

Can reproduce and test in dev mode and prod build. Tested manually in latest Chrome, FF, Safari

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally - two tests are failing for me locally but they also fail on main and unrelated to these changes.
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

issue seems to be with newEnv[newKey] = value. using reduce instead to explicitly maintain the order of entries seems to resolve the issue

olaservo
olaservo previously approved these changes Mar 24, 2025
Copy link
Collaborator

@olaservo olaservo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching and fixing this!

@olaservo
Copy link
Collaborator

Looks like you just need to fix formatting and then I can merge:

npx prettier --write client/src/components/Sidebar.tsx

@olaservo olaservo mentioned this pull request Mar 24, 2025
9 tasks
@markacianfrani markacianfrani requested a review from olaservo March 24, 2025 16:59
@markacianfrani
Copy link
Contributor Author

whoops, sorry about that

@olaservo olaservo enabled auto-merge March 24, 2025 18:00
@olaservo olaservo merged commit 731cee8 into modelcontextprotocol:main Mar 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment Variables Input Values Swap Unexpectedly
2 participants