Fix ESLint rules-of-hooks warnings #218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #217 about the linter's warning that Hooks must be run in order each time.
handleApproveSampling
andhandleRejectSampling
constants down below all the hooks for clarity. There are a lot of hooks so finding the end of them is a scroll, and these function constants aren't referenced until the rendering section below anyway.connectMcpServer
method as a dependency, quieting the ESLint complaint about it.Motivation and Context
Software correctness.
How Has This Been Tested?
inspector/client
eslint
Previous output
After fix (other warnings still exist, but are out of scope for this fix)
oauth/callback
, tested with this minimal GitHub OAuth MCP server.Breaking Changes
Nope.
Types of changes
Checklist
Additional context
Fixes #217 which was raised in response to this PR which was going to incidentally suppress rules-of-hooks warnings. I wanted to fix the problem instead.