Mark DSL functions for types as public #472
Merged
+870
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpavlov
force-pushed
the
expose-request-dsl
branch
from
87287b7 to
e44cc21
Compare
kpavlov
force-pushed
the
expose-request-dsl
branch
from
e44cc21 to
171bc82
Compare
- Added unit tests for multiple DSL builders including tools, sampling, resources, prompts, logging, and initialization. - Updated AGENTS.md with testing guidelines for `shouldNotBeNull` blocks.
kpavlov
changed the title
kpavlov
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The dsl builders in this commit were mistakenly marked internal and are therefore unusable. I have simply marked them as public.
How Has This Been Tested?
Breaking Changes
No
Types of changes
Checklist
Additional context