Skip to content

Change ErrorCodeSerializer descriptor kind #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2025

Conversation

Leesin0222
Copy link
Contributor

@Leesin0222 Leesin0222 commented Mar 16, 2025

Summary of Changes

  • Modified the ErrorCodeSerializer class by changing the PrimitiveSerialDescriptor type from PrimitiveKind.STRING to PrimitiveKind.INT.

Motivation and Context

  • Problem Solved: When using PrimitiveKind.STRING in the ErrorCodeSerializer, errors could occur due to type mismatches during serialization and deserialization. Since ErrorCode.code is an Int, it should be handled consistently by using PrimitiveKind.INT.

Breaking Changes

  • Change Impact: This change modifies the serialization and deserialization logic for ErrorCodeSerializer. If any existing code expects String type instead of Int for the ErrorCode values, those parts may need to be updated to handle the Int type properly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the [MCP Documentation](https://modelcontextprotocol.io)
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

X

bacause The opt-in annotation is redundant: no matching experimental API is used
@Leesin0222 Leesin0222 changed the title Chang descriptor kind Change descriptor kind Mar 17, 2025
@Leesin0222 Leesin0222 changed the title Change descriptor kind Change ErrorCodeSerializer descriptor kind Mar 17, 2025
Copy link
Contributor

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@e5l
Copy link
Contributor

e5l commented Mar 26, 2025

Hey @Leesin0222, thanks for the PR. Will merge after CI run

@Leesin0222
Copy link
Contributor Author

@e5l Thank you very much :) have a good day!

@e5l e5l enabled auto-merge (squash) March 26, 2025 09:03
@e5l e5l merged commit 1fbf819 into modelcontextprotocol:main Mar 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants