Skip to content

feat: add message field to ProgressNotification according to 2025-03-26 spec #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SeanChinJunKai
Copy link
Contributor

Motivation and Context

This PR adds message field to ProgressNotification to provide descriptive status updates

How Has This Been Tested?

NA

Breaking Changes

NA

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

References: https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/schema/2025-03-26/schema.ts#L294

@SeanChinJunKai
Copy link
Contributor Author

SeanChinJunKai commented Apr 9, 2025

I have a question why do we have ProgressNotification and Notification? The only difference is the _meta and method fields.

@Junjun13910
Copy link

Carefull about your cctv nvr use in eseecloud

@e5l e5l requested review from Copilot and e5l April 9, 2025 18:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@e5l e5l enabled auto-merge (squash) April 10, 2025 08:21
@Junjun13910
Copy link

Junjun13910 commented Apr 10, 2025 via email

@e5l e5l disabled auto-merge April 10, 2025 14:21
@e5l e5l enabled auto-merge (squash) April 10, 2025 14:21
@e5l e5l disabled auto-merge April 17, 2025 07:20
@e5l e5l enabled auto-merge (squash) April 17, 2025 07:20
@Junjun13910
Copy link

You know what you guys can move the token anyway so just have it and good bless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants