fix(server): match Accept header as media ranges#912
Open
devcrocod wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Streamable HTTP server Accept header validation by parsing it into proper media ranges and matching via ContentType.match, ensuring wildcards and quality factors are handled correctly and preventing substring false-positives (e.g., application/jsonp no longer matching application/json) in the kotlin-sdk-server transport layer.
Changes:
- Replace naive substring-based
Acceptmatching withparseHeaderValue(...)+ContentType.match(...), honoring wildcards andq=0. - Add parameterized tests covering valid/invalid
Acceptheaders for POST (JSON/SSE dual-accept gate) and GET (SSE accept gate). - Add a regression test ensuring an unparsable
Acceptheader is rejected without delivering messages to the transport.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| kotlin-sdk-server/src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/StreamableHttpServerTransport.kt | Implements media-range parsing for Accept checks to correctly enforce JSON/SSE accept requirements. |
| kotlin-sdk-server/src/jvmTest/kotlin/io/modelcontextprotocol/kotlin/sdk/server/StreamableHttpServerTransportTest.kt | Adds coverage for wildcard, case/parameter variations, q=0, and unparsable Accept header behaviors for POST/GET. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header is now parsed into media ranges (
parseHeaderValue+ContentType.match)Breaking Changes
none
Types of changes
Checklist