Skip to content

feat(compat): add StreamableHTTPServerTransport alias and EventStore …

6f5ee9c
Select commit
Loading
Failed to load commit list.
Closed

feat(compat): re-export StreamableHTTPServerTransport + EventStore types from /node #1904

feat(compat): add StreamableHTTPServerTransport alias and EventStore …
6f5ee9c
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 16, 2026 in 9m 10s

Code review found 1 important issue

Found 3 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 1
🟡 Nit 0
🟣 Pre-existing 0
Severity File:Line Issue
🔴 Important packages/middleware/node/src/index.ts:4-7 @deprecated still stripped from published .d.mts — 'Fixed' resolution incomplete

Annotations

Check failure on line 7 in packages/middleware/node/src/index.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

@deprecated still stripped from published .d.mts — 'Fixed' resolution incomplete

The "Fixed" resolution restored `@deprecated` only as inline JSDoc on the export *specifier* — tsdown's dts bundler still flattens that into a bare `NodeStreamableHTTPServerTransport as StreamableHTTPServerTransport` with no JSDoc (verified: `dist/index.d.mts:516`, and `grep -in deprecated dist/index.d.mts` finds only the unrelated DNS-rebinding option deprecations at 364/370/376). Consumers of the published package still get no IDE strikethrough / `no-deprecated` lint warning. Switch to the `ex