-
Notifications
You must be signed in to change notification settings - Fork 43
Clean up use of non-semantical macros for font selection #2567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To get consistent formatting of subscripted variables inside Modelica source code, this involves changes in many places besides those where there used to be a \texttt
…ion...' It was a mistake to think that the last entry in this list was a typo. In a subsequent commit, I'll suggest writing it in a way with less risk of misinterpretation.
Similarly also for actualSteram.
This gives more consistent spacing around the aligned equality operator, compared with all the other equation* environments.
Following the style recentry introduced in stream.tex.
In the past, these vector variables used to be formatted in boldface. Now, I don't know how we want it, but this commit at least makes formatting consistent. If we want boldface, we should use \mathbf.
This change is related to the other changes where operators with function calling syntax are mentioned.
The use of boldface was inconsistent with the rest of the listing anyway.
…irect use of \textbf
Since most of these should use math, it also looks better if none of the items use boldface.
I skimmed the document, and as far as I could tell, this always gives a better result.
Similar sentences in other rows of the table are not written as separate paragraph, so this just makes the treatment equal across the table rows.
This makes sense when thinking of this lstlisting as a quick and dirty way of writing an equation with lots of inline code, and then this 'and' would have been inside \text{...}.
I've now taken the time to go through this chapter more carefully than the other chapters, hoping that this will be possible to use as example when later returning to do more careful cleanup of the other chapters.
|
I've now spent more time than planned on tidying up chapter Arrays in the spirit of this PR, but I really don't think we should do the same with the other chapters, considering how much this would delay closing this disruptive (as in being very prone to conflict with other changes) PR. As far as I can tell, the requested changes have been addressed, and what remains is to fix the continuous integration failures. |
A heading is a heading even without a trailing colon. Maybe the colons were a rest from a time when these weren't normal headings, but some sort of boldface at the start of a paragram...
Based on #2577 it seems a matter of cherry-picking some or all of the following. The last one is needed, the first might be good to add in a separate PR. I don't know about the middle one: |
|
OK, I was fooled by my local successful LaTeXML builds. I don't think we need 1a97cd7 any more (see comment to the commit itself), so I'll start by cherry-picking the other changes. |
HansOlsson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good new.
|
Good. Then I suggest you merge and we remove the branch. |
Will do shortly. |
Fixes #2503.