Implement ie.start #4269
Open
Implement ie.start #4269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiankral
approved these changes
Jan 16, 2024
Contributor
christiankral
left a comment
christiankral
left a comment
There was a problem hiding this comment.
This is a fully backwards compatible change. So this is good.
beutlich
reviewed
Jan 16, 2024
| color={0,0,255})); | ||
| connect(loadControl.y, switch.control[1]) annotation (Line( | ||
| points={{-19,80},{-10,80},{-10,62}}, color={255,0,255})); | ||
| points={{-19,80},{-10,80},{-10,61.3333}}, |
Member
There was a problem hiding this comment.
Is the pixel change intentional?
| points={{-19,80},{-10,80},{-10,62}}, color={255,0,255})); | ||
| connect(loadControl.y, switch.control[3]) annotation (Line( | ||
| points={{-19,80},{-10,80},{-10,62}}, color={255,0,255})); | ||
| points={{-19,80},{-10,80},{-10,62.6667}}, |
Member
There was a problem hiding this comment.
Is the pixel change intentional?
Member
|
Since feature freeze for 4.1.0 was last Friday, I guess this will have to wait for the release after that. |
dietmarw
requested changes
Jan 17, 2024
Member
dietmarw
left a comment
dietmarw
left a comment
There was a problem hiding this comment.
Wait until 4.2.0 see also https://github.com/modelica/ModelicaStandardLibrary/wiki/MSL-v4.1.0-release
Contributor
|
@AHaumer this is really a minor fix, so it's not a big deal, but I'd prefer that we stick to the rules we gave ourselves: after Jan 12 we should only try to close pending PRs for 4.1.0 (there are plenty), not opening other ones. Thanks! |
tobolar
added
L: Electrical.Machines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented start value for ie (excitation current) of electrical excited synchronous machine (Electrical,Machines and Magnetic.FundamentalWave) as requested in #4242