Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #4424 #4566

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Fix for #4424 #4566

merged 1 commit into from
Mar 6, 2025

Conversation

Esther-Devakirubai
Copy link
Contributor

Backports #4547

@casella @Esther-Devakirubai
Fixes for #4424 (#4547)
d6143ae 
Added small pressure losses to DynamicPipeEnergyConservationCheck2 to avoid index reduction with the fixed pressure boundary.
Changed to FixedInitial initialization to avoid unspecified initial conditions
@Esther-Devakirubai Esther-Devakirubai added the L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined label Mar 6, 2025
@Esther-Devakirubai Esther-Devakirubai added this to the MSL4.1.0 milestone Mar 6, 2025
@Esther-Devakirubai Esther-Devakirubai mentioned this pull request Mar 6, 2025
Merged
HansOlsson
HansOlsson approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@casella casella merged commit 7469f20 into maint/4.1.x Mar 6, 2025
6 checks passed
@casella casella deleted the bp_pr4547 branch March 6, 2025 15:15
@MatthiasBSchaefer MatthiasBSchaefer mentioned this pull request Mar 7, 2025
Merged
@casella casella mentioned this pull request Mar 7, 2025
Closed
@beutlich beutlich changed the title Fixes for #4424 (#4547) Fix for #4424 Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltelenz maltelenz maltelenz approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees
No one assigned
Labels
L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Esther-Devakirubai @maltelenz @HansOlsson @casella