Only force CMAKE_INSTALL_PREFIX if the user didn't specify it. #4603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forcing an override of `CMAKE_INSTALL_PREFIX` is not friendly, since users might expect to set it themselves when they run cmake.
beutlich
added
L: Resources
beutlich
approved these changes
Mar 26, 2025
Member
beutlich
left a comment
beutlich
left a comment
There was a problem hiding this comment.
Thanks. See https://stackoverflow.com/a/16076855.
HansOlsson
reviewed
Mar 26, 2025
maltelenz
commented
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing an override of
CMAKE_INSTALL_PREFIXis not friendly, since users might expect to set it themselves when they run cmake.We have a real-world use case where we do set this ourselves when running cmake. We build the libraries on each platform separately, setting
CMAKE_INSTALL_PREFIXto a nice place outside of the source. Only afterwards do we combine all of the results from each platform and put them in the final location.