Skip to content

Conversation

@nl78
Copy link
Contributor

@nl78 nl78 commented Nov 5, 2024

No description provided.

Copy link
Collaborator

@chrbertsch chrbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!
Regarding the page https://github.com/grouperenault/fmutool/tree/main/doc that you link from "ExamplesURL":
Could you please add information, with which FMUs from which exporting tools you have tested fmutool? (including the References FMUs?)
And with which tools and checkers from https://fmi-standard.org/validation/ you tested the re-exported FMUs?

@nl78
Copy link
Contributor Author

nl78 commented Nov 6, 2024

I just added https://github.com/grouperenault/fmutool/tree/main/doc#readme
Current (public) automated tests suite includes only 1 FMU.

Copy link
Collaborator

@t-sommer t-sommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO the name "fmutool" conflicts with the trademark usage guidelines of the FMI:

The use of the letters FMI or FMU in a product name, reference or other relevant context is not allowed when:
[...]
The use can be interpreted as a variant, subset or improvement of the original FMI standard (e.g. using a tool name, say FMIplus, that can be interpreted as supporting with extensions/improvements with respect to one of the FMI versions),

@nl78
Copy link
Contributor Author

nl78 commented Nov 6, 2024

Could the name "fmutool" lead someone to believe it is a variant of the FMI standard?
Changing the name at this stage would be difficult (it is use internally at Renault and publicly released). What alternatives?

@t-sommer
Copy link
Collaborator

t-sommer commented Nov 6, 2024

Maybe something like "Renault FMU Tool"?

@nl78
Copy link
Contributor Author

nl78 commented Nov 6, 2024

Renault logo would be just beside the tool name. So would "FMU tool" instead of "FMUtool" be suitable?
(putting "Renault" in the name itself could lead to trademark concern)

@chrbertsch
Copy link
Collaborator

So would "FMU tool" instead of "FMUtool" be suitable?

We discussed the name in the FMI Steering Committee and kindly ask to change or extend the name for two reasons:

  • due to the very generic name "FMU tool" it could be confused with artefacts officially provided by the FMI project, especially at it modifies the modelDescription.xml file, which should not be done by non-experts. Can you make the aspect of modifying the FMU more explicit?
  • With the name "FMU tool" it will be very hard to get found with a search machine, as there will be many hits for other FMI supporting tools

@nl78
Copy link
Contributor Author

nl78 commented Dec 6, 2024

Renaming will involve some rework. Before proceeding, I would like to ensure that the new name is acceptable :
we selected 2 candidates : "FMU Python Toolbox" or "FMU Manipulation Toolbox". Do they meet FMI Guidelines ?

@chrbertsch
Copy link
Collaborator

Renaming will involve some rework. Before proceeding, I would like to ensure that the new name is acceptable : we selected 2 candidates : "FMU Python Toolbox" or "FMU Manipulation Toolbox". Do they meet FMI Guidelines ?

Thanks, both suggestions are fine for us.
(I personally think that second is more descriptive for what your tool does)

@nl78 nl78 marked this pull request as draft December 6, 2024 18:23
@nl78 nl78 changed the title Add fmutool to the tools list Add FMU Manipulation Toolbox to the tools list Dec 9, 2024
@nl78 nl78 marked this pull request as ready for review December 9, 2024 10:29
@nl78
Copy link
Contributor Author

nl78 commented Dec 9, 2024

I proceeded to the renaming and rebase on last commit. Please, let me know if any issue left.

Copy link
Collaborator

@chrbertsch chrbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the renaming

@nl78 nl78 requested a review from t-sommer December 10, 2024 09:57
@t-sommer t-sommer merged commit f441a98 into modelica:main Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants