Skip to content

Conversation

@abeguin-pve
Copy link
Contributor

Actions done :

  • update of the tools.json file to add a new fmi tool, named SIMSEN.
  • add new image in /logos folder to act as SIMSEN logo.

Message :
I am happy to have implemented the amazing fmi standard in our product. I would be happy to see our tool on the fmi tools page. I thank you in advance for handling this pull request.

BR,

Antoine, for the SIMSEN Dev Team

Update tools.json to add a new fmi tool, named SIMSEN
Add file simsen.png into /logos subfolder to display as logo in fmi tools page.
Copy link
Collaborator

@chrbertsch chrbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding your tool!
It would be great if you could provide provide compatibility information (see https://github.com/modelica/fmi-standard.org/blob/main/CONTRIBUTING.md#compatibility-information), i.e. how you tested your FMI implementation? (Could also be in a separate Pull Request.) Benefit: your tool will get the "yellow star" and be listed on the top.

@abeguin-pve
Copy link
Contributor Author

Dear Mr. Bertsch,

thank you for your quick approval of my pull request. I appreciate your suggestion to provide fmi compatibility information for the SIMSEN tool. I agree with you, we should provide such information. In fact, this info is available to our customer, from within our SIMSEN package. So, it will take me some time to extract this information and make it available from a public url that can be linked into the fmi toll table. So, I would prefer to do it within a separate pull request, as this task might take me some time.

Thank you in advance for your integration work.

BR,

Antoine

@abeguin-pve
Copy link
Contributor Author

Thanks for adding your tool! It would be great if you could provide provide compatibility information (see https://github.com/modelica/fmi-standard.org/blob/main/CONTRIBUTING.md#compatibility-information), i.e. how you tested your FMI implementation? (Could also be in a separate Pull Request.) Benefit: your tool will get the "yellow star" and be listed on the top.

Good morning,

apart from the need to provide FMI compatibility info, do you need any other actions from my side to finalize this Pull Request so that the SIMSEN tool appears in the FMI tools page ? As I my new to the GitHib environment, I just want to ensure that I have not missed any steps. Thanks for your work,

BR,

Antoine

@chrbertsch chrbertsch merged commit eb31132 into modelica:main Dec 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants