Skip to content

Conversation

pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented Nov 15, 2024

As the title says

Copy link
Collaborator

@yxdyc yxdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, plz see a few suggestions as commented

add_uid_column, batch_format='pyarrow').materialize()
dataset_with_id.map_batches(calculate_minhash,
batch_format='pyarrow').groupby(
HashKeys.minhash).aggregate(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although we are (ideally) optimizing this via multiple distributed UnionSets, it is worth profiling this line and (then co-optimizing with Ray-Team)

@yxdyc yxdyc requested a review from chenyushuo December 20, 2024 03:27
@yxdyc yxdyc added dj:op issues/PRs about some specific OPs dj:dist issues/PRs about distributed data processing dj:efficiency regarding to efficiency issues and enhancements labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dj:dist issues/PRs about distributed data processing dj:efficiency regarding to efficiency issues and enhancements dj:op issues/PRs about some specific OPs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants