-
Notifications
You must be signed in to change notification settings - Fork 20
[bridge] Support GPTBridge callback #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Jintao-Huang
merged 10 commits into
modelscope:main
from
Jintao-Huang:support_gpt_bridge_callback
Apr 1, 2026
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
42473b3
update readme
Jintao-Huang 78cece0
Merge branch 'main' into support_gpt_bridge_callback
Jintao-Huang 135adad
update
Jintao-Huang 2f4e98a
fix
Jintao-Huang adf859d
update
Jintao-Huang 4af369f
fix
Jintao-Huang 4df68d2
fix
Jintao-Huang 9763b5d
fix
Jintao-Huang b4f9f4b
fix
Jintao-Huang 45bc01b
fix
Jintao-Huang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bridge's internal conversion logic (e.g., in
_set_state_dict) explicitly calls.load()on every value in the state dict. If the user-providedconverterreturns a rawtorch.Tensorinstead of aLazyTensor(which happens if they call.load()inside the converter to modify the weight), the subsequent code will fail with anAttributeError. You should ensure that any value returned by the converter that doesn't have a.load()method is wrapped appropriately to maintain compatibility with the rest of the bridge.