-
Notifications
You must be signed in to change notification settings - Fork 994
[megatron] support blockwise fp8 #6633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Jintao-Huang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates support for blockwise FP8 within the Megatron framework. The primary changes involve adjusting the padding calculation logic to meet the specific requirements of blockwise FP8 and optimizing weight handling by ensuring that gradient tracking is disabled during the loading and exporting of model weights. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for the blockwise FP8 recipe by adjusting sequence padding logic. It also enhances weight loading and exporting efficiency by wrapping these operations in torch.no_grad() contexts, which is a good practice. The changes are logical, but there is a minor opportunity to improve code clarity by replacing a magic number with a named constant.
| if args.fp8_recipe == 'blockwise': | ||
| padding_to = (padding_to or 1) * 128 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The magic number 128 is introduced here for the blockwise FP8 recipe. To improve readability and maintainability, consider defining this as a named constant at the module level, for example: BLOCKWISE_FP8_PADDING = 128. This would make the code's intent clearer, especially as it relates to hardware or algorithm-specific requirements for the blockwise FP8 format.
…p8' into support_blockwise_fp8
No description provided.