-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update moe.sh #7375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update moe.sh #7375
Conversation
Summary of ChangesHello @Itime-ren, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the moe.sh script, adjusting GPU settings, dataset paths, and training intervals. My review identifies a few key issues: a configuration mismatch between the number of visible GPUs and the number of processes, which will lead to underutilization of resources; the use of a hardcoded absolute path for the dataset, which harms the script's portability; and setting evaluation/saving intervals to a very low value, which may be suitable for debugging but is inefficient for general use. Addressing these points will improve the script's correctness and reusability.
| PYTORCH_CUDA_ALLOC_CONF='expandable_segments:True' \ | ||
| NPROC_PER_NODE=2 \ | ||
| CUDA_VISIBLE_DEVICES=0,1 \ | ||
| CUDA_VISIBLE_DEVICES=0,1,2,3 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| --merge_lora false \ | ||
| --dataset 'swift/Qwen3-SFT-Mixin#2000' \ | ||
| 'swift/self-cognition:empty_think#600' \ | ||
| --dataset '/root/autodl-tmp/swift_finetune_data/qwen3_finetune_self_cognition.jsonl' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dataset is specified with a hardcoded absolute path (/root/...). This makes the script non-portable and dependent on a specific user's environment, which is not ideal for an example script in a shared repository. Please consider using a relative path, an environment variable, or reverting to the previous method of using dataset identifiers from a registry to ensure the script is reusable.
| --eval_interval 5 \ | ||
| --save_interval 5 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The eval_interval and save_interval have been set to a very low value of 5. While this can be useful for rapid debugging, it will cause frequent evaluations and checkpointing, introducing significant overhead and consuming disk space quickly during a normal training run. If this change is for debugging, it should not be merged. For a general-purpose example script, a more conservative value (like the previous 200) is recommended.
PR type
PR information
Write the detail information belongs to this PR.
Experiment results
Paste your experiment result here(if needed).