fix(cellbudgetfile): fix get_ts support for aux vars #2648
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2648 +/- ##
==========================================
- Coverage 55.5% 36.1% -19.5%
==========================================
Files 644 360 -284
Lines 124135 65486 -58649
==========================================
- Hits 68947 23641 -45306
+ Misses 55188 41845 -13343 🚀 New features to boost your workflow:
|
| """ | ||
| out = np.ma.zeros(self.nnodes, dtype=np.float32) | ||
| out = np.ma.zeros(self.nnodes, dtype=data["q"].dtype) |
There was a problem hiding this comment.
unrelated fix to avoid unwanted rounding in the full3D code path
| spd = getattr(self, "stress_period_data") | ||
| if isinstance(item, MfList): | ||
| if not isinstance(item, list) and not isinstance(item, tuple): | ||
| if not isinstance(item, (list, tuple)): |
There was a problem hiding this comment.
unrelated opportunistic simplification
| [(layer, row, column), (layer, row, column), ...]. The layer, | ||
| row, and column values must be zero based. | ||
| idx : int, tuple of ints, or list of such | ||
| Acceptable values depend on grid type: |
There was a problem hiding this comment.
Described required syntax for each grid type as requested. But I tentatively reworked this to accept a properly-shaped tuple for the grid type. Having to pass a 3-tuple with dummy values was very awkward and I'm tempted to call this a fix even though it's a breaking change. I don't know of anywhere else this is done that way. Wondering how others feel about this.
1 participant
close #2647, correcting initial buggy implementation of #2270