You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a parameter vertices_coords to VertexGrid and UnstructuredGrid init methods, indicating whether vertices are in local or global coordinates. Default to "local". This fixes#2388 by making it possible to avoid repeating the coordinate transformation. The parameter is not applicable to StructuredGrid because vertex coordinates are not provided to its init method.
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.3%. Comparing base (556c088) to head (0aedfd4). ⚠️ Report is 119 commits behind head on develop.
After a closer look I see that the same double transform issue applies to cell centers too for unstructured grids. But not vertex grids, which calculate cell centers from vertices. So a new parameter should apply not only to vertices but to any manually specified grid feature coordinates. So it should probably be named differently. Maybe global_xy? This is consistent with a similar parameter in mp7particledata.py, the only difference is that one controls what is output and this one will indicate what is provided as input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a parameter
vertices_coordstoVertexGridandUnstructuredGridinit methods, indicating whether vertices are in local or global coordinates. Default to"local". This fixes #2388 by making it possible to avoid repeating the coordinate transformation. The parameter is not applicable toStructuredGridbecause vertex coordinates are not provided to its init method.