fix(cvfdutil): add non-convergence check to shapefile_to_cvfd - #2688
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2688 +/- ##
===========================================
+ Coverage 55.5% 72.3% +16.8%
===========================================
Files 644 667 +23
Lines 124135 130318 +6183
===========================================
+ Hits 68947 94290 +25343
+ Misses 55188 36028 -19160
🚀 New features to boost your workflow:
|
wpbonelli
marked this pull request as ready for review
January 25, 2026 18:20
jdhughes-dev
approved these changes
Jan 29, 2026
jlarsen-usgs
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test the hanging node check on Voronoi grids. Mention that failure is possible with grids that have artifacts like near-duplicate vertices. Add an optional non-convergence check to the method. I figure it could be always on, as it only triggers if no progress is made by the algorithm, but not 100% sure about this, so kept it optional. Close #2427