Skip to content

fix(cvfdutil): add non-convergence check to shapefile_to_cvfd - #2688

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:fix-2427
Jan 30, 2026
Merged

fix(cvfdutil): add non-convergence check to shapefile_to_cvfd#2688
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:fix-2427

Conversation

@wpbonelli

Copy link
Copy Markdown
Member

Test the hanging node check on Voronoi grids. Mention that failure is possible with grids that have artifacts like near-duplicate vertices. Add an optional non-convergence check to the method. I figure it could be always on, as it only triggers if no progress is made by the algorithm, but not 100% sure about this, so kept it optional. Close #2427

@codecov

codecov Bot commented Jan 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 44.44444% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.3%. Comparing base (556c088) to head (9a4865c).
⚠️ Report is 119 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/utils/cvfdutil.py 44.4% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2688      +/-   ##
===========================================
+ Coverage     55.5%    72.3%   +16.8%     
===========================================
  Files          644      667      +23     
  Lines       124135   130318    +6183     
===========================================
+ Hits         68947    94290   +25343     
+ Misses       55188    36028   -19160     
Files with missing lines Coverage Δ
flopy/utils/cvfdutil.py 81.0% <44.4%> (-1.6%) ⬇️

... and 562 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli
wpbonelli marked this pull request as ready for review January 25, 2026 18:20
@wpbonelli
wpbonelli merged commit 2893949 into modflowpy:develop Jan 30, 2026
20 checks passed
@wpbonelli
wpbonelli deleted the fix-2427 branch January 30, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: flopy.utils.cvfdutil.shapefile_to_cvfd gets stuck

3 participants