This repository was archived by the owner on Oct 19, 2024. It is now read-only.
extracts versions #789
Open
extracts versions #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… extracts-versions
Geometrically
suggested changes
Dec 20, 2023
| // Filters out projects for which we are a member of the team (or a mod) | ||
| // These are projects we have internal access to and can potentially see even if they are hidden | ||
| // This is useful for getting visibility of versions, or seeing analytics or sensitive team-restricted data of a project | ||
| pub async fn filter_enlisted_projects_ids( |
There was a problem hiding this comment.
weird func name here "enlisted_project_ids"
| Ok(return_versions) | ||
| } | ||
|
|
||
| pub async fn filter_enlisted_version_ids( |
There was a problem hiding this comment.
same here, enlisted is a weird term for this, what does it even do?
| pub categories: Vec<String>, | ||
| pub additional_categories: Vec<String>, | ||
| pub versions: Vec<VersionId>, | ||
| pub public_versions: Vec<VersionId>, |
There was a problem hiding this comment.
why still have this attr on query project? isn't the point of this PR to remove it?
| cfg.route("search", web::get().to(project_search)); | ||
| cfg.route("projects", web::get().to(projects_get)); | ||
| cfg.route("projects", web::patch().to(projects_edit)); | ||
| cfg.route("projects_versions", web::get().to(projects_version_list)); |
There was a problem hiding this comment.
why is this route registered twice?
| )) | ||
| } | ||
| } | ||
|
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MOD-550
In addition, fixed a bug or two I found with the filter_authorized_versions method (and similar), and restructured and renamed them to avoid it