Update GitHub actions to latest #73
Conversation
|
So the problem here is that project |
|
Yeah, staging gets wiped from time to time. Weird that it depends on a specific project... seems like it should not be the case |
|
Yeah, it is just for logging. I could move that down the function after the debugMode/dry-run check? minotaur/src/main/java/com/modrinth/minotaur/TaskModrinthUpload.java Lines 96 to 97 in a151c42 |
By using System.getenv on a static final field, the environment variable is never updated. This means you have to kill the Gradle daemon if you forgot the token the first time!
They were using the remote one, which makes it impossible to test changes!
This either continues onwards when in debug mode, or throws a descriptive exception (rather than an NPE).
|
"This'll be a simple two line change" he said. Nothing's simple in Minecraft modding :D:. There's a remaining issue with versioned dependencies also not existing on staging. I'm assuming there's no test data your staging env is provisioned with every time? In that case, it might just be easier to point the plugin at prod? |
|
Yeah, should probably just point at prod. Can use this project, we use it for testing elsewhere lol https://modrinth.com/mod/mudmod |
Also improve error message in the event the dependency cannot be resolved.
2 participants
Not tested, but should work. I don't believe the breaking changes in upload-artifact affect Minotaur.
Fixes #70 (via 771354e).