Skip to content

Fixed build ci job not respecting npm version bump #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aahrun merged 1 commit into from
Dec 5, 2025
Merged

Fixed build ci job not respecting npm version bump #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ on:
- main

workflow_call:
inputs:
ref:
type: string
required: false

jobs:
build:
Expand All @@ -23,6 +27,8 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
with:
ref: ${{ inputs.ref || github.sha }}

- uses: ./.github/actions/setup

Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ jobs:

outputs:
version: ${{ steps.bump.outputs.version }}
commit_sha: ${{ steps.get_sha.outputs.sha }}

steps:
- name: Setup Node
Expand Down Expand Up @@ -74,9 +75,15 @@ jobs:
export VERSION=$(jq -r '.version' package.json)
echo "version=${VERSION}" >> $GITHUB_OUTPUT

- name: Get new commit SHA
id: get_sha
run: echo "sha=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT

build:
needs: [version]
uses: ./.github/workflows/build.yaml
with:
ref: ${{ needs.version.outputs.commit_sha || github.sha }}

publish:
name: Publish extension
Expand All @@ -90,6 +97,8 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
with:
ref: ${{ needs.version.outputs.commit_sha || github.sha }}

- uses: ./.github/actions/setup

Expand Down