Skip to content

Cache the active SDK to avoid repeated queries#41

Merged
abduld merged 1 commit intomodular:mainfrom
abduld:abduld/cache-2
Jan 6, 2026
Merged

Cache the active SDK to avoid repeated queries#41
abduld merged 1 commit intomodular:mainfrom
abduld:abduld/cache-2

Conversation

@abduld
Copy link
Contributor

@abduld abduld commented Dec 20, 2025

Currently the extension tries to find the SDK path at each event. As a result you get

["INFO" - 6:50:06 PM] Found SDK with version 0.0.0
["INFO" - 6:50:06 PM] Monorepo SDK found, prioritizing that over Python environment.
["INFO" - 6:50:08 PM] Found SDK with version 0.0.0
["INFO" - 6:50:08 PM] Monorepo SDK found, prioritizing that over Python environment.
["INFO" - 6:57:21 PM] Found SDK with version 0.0.0
["INFO" - 6:57:21 PM] Monorepo SDK found, prioritizing that over Python environment.
["INFO" - 6:57:21 PM] Found SDK with version 0.0.0
["INFO" - 6:57:21 PM] Monorepo SDK found, prioritizing that over Python environment.

and it slows down every operation. This caches the SDK path if defined so it's persistent across the session

@github-actions
Copy link

github-actions bot commented Dec 20, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@abduld
Copy link
Contributor Author

abduld commented Dec 29, 2025

I have read the CLA Document and I hereby sign the CLA

modular-cla-bot bot added a commit to modular/cla that referenced this pull request Jan 6, 2026
Copy link

@alycm alycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abduld abduld merged commit 3ba0a67 into modular:main Jan 6, 2026
6 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants