Merged
Conversation
|
Collaborator
Author
I tried but wasn't able to get them working. I'm going to have to rebuild our test infrastructure; |
mckaydavis
approved these changes
Jul 15, 2025
mckaydavis
left a comment
mckaydavis
left a comment
There was a problem hiding this comment.
Can please you file / link follow-up tickets for testing?
Comment on lines
+139
to
+142
| // this.envManager.showBazelwRunInstallPrompt( | ||
| // 'The LLDB Debug Adapter seems to be corrupted.', | ||
| // sdk.homePath, | ||
| // ); |
There was a problem hiding this comment.
Why is this commented out but not removed?
If this is not released to users yet, I recommend either re-enabling it.
(or just removing it)
This was referenced Jul 16, 2025
Merged
AmaranthineCodices
added a commit
that referenced
this pull request
Jul 16, 2025
This will allow us to test SDK-related features again in the aftermath of #5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the legacy SDK loading code, including our automatic use of
magic. This breaks all test cases.We now search for a Python environment using the Python extension's APIs, then try to load MAX from it.