Skip to content

feat(enhanced): exclude shares by semver #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: share-filter
Choose a base branch
from

Conversation

ScriptedAlchemy
Copy link
Member

@ScriptedAlchemy ScriptedAlchemy commented May 2, 2025

This pull request introduces several updates across multiple files, focusing on improving the build process, enhancing test configurations, and extending functionality in the ConsumeSharedPlugin class. The most significant changes include switching from npm to pnpm for task execution, adding new debugging configurations, enhancing the ConsumeSharedPlugin to support version exclusion, and updating test coverage for additional directories.

Testing Enhancements:

  • packages/enhanced/jest.config.ts: Expanded the testMatch configuration to include tests in the test/compiler-unit directory, increasing test coverage.
  • package.json: Updated the enhanced:jest script to include the test/compiler-unit directory, aligning with the extended test coverage.

Plugin Functionality Extensions:

Dependency and Build Improvements:

These changes collectively enhance the development workflow, improve testing capabilities, and extend the functionality of the ConsumeSharedPlugin to better handle module sharing scenarios.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: 7b7c3d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy ScriptedAlchemy changed the base branch from main to share-filter May 2, 2025 01:32
Copy link

netlify bot commented May 2, 2025

Deploy Preview for module-federation-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 440e010
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/6814209078a826000815e1c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant