-
-
Notifications
You must be signed in to change notification settings - Fork 302
feat(enhanced): exclude shares by semver #3744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: share-filter
Are you sure you want to change the base?
Conversation
|
❌ Deploy Preview for module-federation-docs failed. Why did it fail? →
|
…irtual file system integration
This pull request introduces several updates across multiple files, focusing on improving the build process, enhancing test configurations, and extending functionality in the
ConsumeSharedPlugin
class. The most significant changes include switching fromnpm
topnpm
for task execution, adding new debugging configurations, enhancing theConsumeSharedPlugin
to support version exclusion, and updating test coverage for additional directories.Testing Enhancements:
packages/enhanced/jest.config.ts
: Expanded thetestMatch
configuration to include tests in thetest/compiler-unit
directory, increasing test coverage.package.json
: Updated theenhanced:jest
script to include thetest/compiler-unit
directory, aligning with the extended test coverage.Plugin Functionality Extensions:
packages/enhanced/src/lib/sharing/ConsumeSharedModule.ts
: Added a newexclude
property to theConsumeOptions
type, allowing specific versions to be excluded during module consumption.packages/enhanced/src/lib/sharing/ConsumeSharedPlugin.ts
: Refactored theConsumeSharedPlugin
class to support theexclude
property, enabling conditional module exclusion based on version constraints. This includes binding thecreateConsumeSharedModule
method for better modularity and maintainability. [1] [2] [3] [4]Dependency and Build Improvements:
packages/chrome-devtools/project.json
: Added adependsOn
configuration to ensure that thebuild:lib
task depends on the parentbuild
task, improving task dependency management.These changes collectively enhance the development workflow, improve testing capabilities, and extend the functionality of the
ConsumeSharedPlugin
to better handle module sharing scenarios.Related Issue
Types of changes
Checklist