-
-
Notifications
You must be signed in to change notification settings - Fork 388
fix(rsbuild-plugin): support app SSR node target with custom environment #4427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ScriptedAlchemy
wants to merge
23
commits into
main
Choose a base branch
from
fix/rsbuild-plugin-app-ssr-node-env
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+601
−54
Open
Changes from 8 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
eb2b405
fix(rsbuild-plugin): support app SSR node target with custom environment
ScriptedAlchemy c5c811b
Merge branch 'main' into fix/rsbuild-plugin-app-ssr-node-env
ScriptedAlchemy 2e0824b
chore(core): trigger canary publish rerun
ScriptedAlchemy d10edc0
chore(core): trigger ci rerun
ScriptedAlchemy 0cab4a9
refactor(rsbuild-plugin): auto-detect default environment by caller
ScriptedAlchemy b2c772c
fix(rsbuild-plugin): scope node target MF to selected env
ScriptedAlchemy 0c3313f
Merge branch 'main' into fix/rsbuild-plugin-app-ssr-node-env
ScriptedAlchemy 2b1724e
Merge remote-tracking branch 'origin/main' into fix/rsbuild-plugin-ap…
ScriptedAlchemy 38715bf
fix(rsbuild-plugin): use SSR MF config for node target envs
ScriptedAlchemy 6e58b44
fix(rsbuild-plugin): scope plugin instance to configured env for ssr
ScriptedAlchemy 36ce9d4
fix(core): support node SSR manifest remotes and auto publicPath
ScriptedAlchemy ac8eefe
fix(rsbuild-plugin): stabilize SSR node manifest/publicPath flow
ScriptedAlchemy 894a4ea
fix(sdk): preserve empty ssrPublicPath semantics
ScriptedAlchemy 7205567
test(enhanced): harden reshake fixture bootstrap
ScriptedAlchemy a0f19f0
test(enhanced): stabilize treeshake fixtures under load
ScriptedAlchemy 5b93df0
build(rsbuild-plugin): use bundler module resolution
ScriptedAlchemy 7acb6b2
test(metro-core): stabilize iOS maestro visibility waits
ScriptedAlchemy 4b16b2d
Merge branch 'main' into fix/rsbuild-plugin-app-ssr-node-env
ScriptedAlchemy 172e069
Merge branch 'main' into fix/rsbuild-plugin-app-ssr-node-env
ScriptedAlchemy 165bd50
Merge remote-tracking branch 'origin/main' into fix/rsbuild-plugin-ap…
ScriptedAlchemy 1eeb46e
Merge branch 'main' into fix/rsbuild-plugin-app-ssr-node-env
ScriptedAlchemy a30201e
Merge branch 'main' into fix/rsbuild-plugin-app-ssr-node-env
ScriptedAlchemy 7f039bb
Merge branch 'main' into fix/rsbuild-plugin-app-ssr-node-env
ScriptedAlchemy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@module-federation/rsbuild-plugin': patch | ||
| --- | ||
|
|
||
| Fix app-mode `target: 'node'` handling to respect custom `environment` names, improve missing-environment errors, auto-detect default environment names by caller/tooling when `environment` is omitted, and ensure selected node-target environments still receive federation plugin injection for commonjs-like SSR outputs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition still allows any MF-format bundler config to enter the node-target processing path even when its name does not match the configured
environment, sotarget: 'node'can still affect extra environments. In builds with multiple MF-format environments, if the selected env is processed first,patchNodeMFConfig(moduleFederationOptions)mutates shared options and later non-selected environments receive node runtime/library settings, which can break client/web outputs; this is reproducible withenvironment: 'ssr'and an env order likessrthenclient.Useful? React with 👍 / 👎.