fix(metro-core): improve Windows metro runtime compatibility#4453
fix(metro-core): improve Windows metro runtime compatibility#4453ScriptedAlchemy wants to merge 15 commits intomainfrom
Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
🦋 Changeset detectedLatest commit: cb3464c The changes in this PR will be included in the next version bump. This PR includes changesets to release 43 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/data-prefetch
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/modern-js-v3
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
Bundle Size Report1 package(s) changed, 40 unchanged.
Total dist: 6.89 MB (+6.7 kB (+0.1%)) |
|
@jbroma hows this? |
jbroma
left a comment
There was a problem hiding this comment.
Changes look good, I would still reconsider this: #4453 (comment)
In current shape, the e2e-metro-windows is not an e2e test and the tests & builds run already as part of the main workflow for whole repo
Description
fix(metro-core): Normalize Windows module paths for module federation
This PR addresses issues with Metro's module federation on Windows environments where native path separators (
\) cause incorrect module resolution and generation. The changes ensure that generated module specifiers and internal paths are consistently normalized to POSIX-style separators (/) to prevent build failures and ensure correct module loading.Specifically, this includes:
toPosixPathhelper function with dedicated unit tests.Related Issue
This PR addresses the broader problem of Windows path resolution in Metro, similar to the scope of #4442.
Types of changes
Checklist