Skip to content

Conversation

@Thegrep01
Copy link
Contributor

@Thegrep01 Thegrep01 commented Jul 15, 2025

Summary

  • - expose loadMetroConfig helper function for integration with Zephyr
  • - expose updateManifest helper function for fixing the remote paths when using Zephyr

@jbroma jbroma requested a review from Copilot July 18, 2025 11:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates Zephyr monitoring/observability platform with Metro Module Federation and React Native Components (RNC). The integration includes local development dependencies, wrapper commands for build processes, and configuration updates across multiple applications.

Key changes:

  • Added local npm links for Zephyr packages using portal dependencies
  • Introduced zephyrCommandWrapper to wrap existing Metro Federation commands
  • Updated Metro configurations to use async withZephyr() wrapper
  • Added new CLI commands and manifest update functionality

Reviewed Changes

Copilot reviewed 16 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Added portal resolutions for local Zephyr packages
packages/plugin-rnc-cli/index.js Exposed loadMetroConfig command for CLI usage
packages/core/src/plugin/manifest.ts Added updateManifest function for runtime manifest updates
packages/core/src/index.ts Exported updateManifest for external usage
packages/core/src/commands/index.ts Added loadMetroConfig command with debug logging
apps/*/react-native.config.js Added Zephyr-wrapped bundle commands
apps/*/metro.config.js Converted to async configuration with Zephyr integration
apps/*/package.json Added Zephyr dependencies and renamed applications
Comments suppressed due to low confidence (2)

@Thegrep01 Thegrep01 force-pushed the zephyr-api-proto branch 2 times, most recently from 87b321a to 64985a6 Compare July 21, 2025 11:52
Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look around this PR, would be nice to clear up the API needs before moving forward with this + PR needs some cleaning up

jbroma

This comment was marked as duplicate.

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remember to run pnpm lint in the root of the monorepo to fix formatting

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last thing and we're g2g 🎉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets undo removal of this file

@jbroma jbroma changed the title Zephyr + metro MF feat: expose loadMetroConfig & updateManifest helpers Aug 4, 2025
@jbroma
Copy link
Member

jbroma commented Aug 4, 2025

@Thegrep01 I've adjusted the PR title and description so we can have this merged sooner 👍

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jbroma jbroma merged commit 9aa073e into module-federation:main Aug 4, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants