feat: Yarn PnP support #370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ha1fstack
commented
Dec 11, 2025
Comment on lines
+16
to
22
| const targetRoot = rootDir || process.cwd(); | ||
| const nodeModulesPath = join(targetRoot, 'node_modules'); | ||
| if (!existsSync(nodeModulesPath)) { | ||
| mkdirSync(nodeModulesPath, { recursive: true }); | ||
| } | ||
| cachedNodeModulesDir = nodeModulesPath; | ||
| return cachedNodeModulesDir; |
Author
There was a problem hiding this comment.
We are using vite project's root instead of traversing for existing folder because pnp doesn't generate node_modules and this seems more natural
Comment on lines
+93
to
+97
| const virtualDirPath = VirtualModule.getVirtualModuleDirPath(); | ||
| (config.resolve as any).alias.push({ | ||
| find: new RegExp(`^${virtualDir}/`), | ||
| replacement: `${virtualDirPath}/`, | ||
| }); |
Author
There was a problem hiding this comment.
using alias to map path to __mf__virtual
| function searchPackageVersion(sharedName: string): string | undefined { | ||
| try { | ||
| const sharedPath = require.resolve(sharedName); | ||
| const sharedPath = require.resolve(sharedName, { paths: [process.cwd()] }); |
Author
There was a problem hiding this comment.
It would be better to use resolved config root instead of cwd but this seems fine for now
gioboa
reviewed
Dec 11, 2025
Collaborator
gioboa
left a comment
gioboa
left a comment
There was a problem hiding this comment.
Thanks for your contribution @ha1fstack
Unfortunately, in these days I'm quite busy and I can't review the PR as fast as I usually do.
I'm going to look at it in the next days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #155
Problem
Yarn PnP can not resolve arbitary qualified resolutions (or packages) whose are not declared explicitly.
However this plugin relies on on-the-fly generated __mf__virtual package inside physical node_modules folder - so it was not compatible
Tries
I first tried to use Vite's virtual module (in-memory) instead of real fs. But it did not work well since this plugin seems to be relying on (the intend is not documented so this is a guess) Vite's dependency pre-bundling - but virtual modules cannot be pre-bundled.
Solution
The root cause was not fs, so I focused on the qualified / unqualified resolution part. Instead of making the generated code as a package (with package.json and importing it with name), using unqualified resolution (real path) + creating alias to that path to keep things simple solved the issue.
Also fixed the problematic searchPackageVersion util too since the packages needs to be resolved from the host package (the service) root not the vite-mf's package root.