Skip to content

Commit 781a01e

Browse files
yajoyajo
committed
[FIX] l10n_fr_siret[_lookup]: remove wrong dependency
Odoo 16 depends on both requests and python-stdnum, so there's no need to specify those dependencies. Besides, [python-stdnum is pinned to 1.16][1]. Thus, when applying OCA/oca-ci#66 locally, the constraint failed. OCA addons should work with the dependencies pinned upstream. [1]: https://github.com/odoo/odoo/blob/fe4d8e8014e50d4335e0a8b052b5098f3a79bcec/requirements.txt#L48 @moduon MT-4520
1 parent e35e644 commit 781a01e

9 files changed

Lines changed: 61 additions & 37 deletions

File tree

‎l10n_fr_siret/README.rst‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ French company identity numbers SIRET/SIREN/NIC
77
!! This file is generated by oca-gen-addon-readme !!
88
!! changes will be overwritten. !!
99
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
10-
!! source digest: sha256:94ef8ef9d4aa0069dd19e158ac7f7c065ba1b283e8ea2b048363dac0c4a8166e
10+
!! source digest: sha256:ea67eff242155510a0475c4cde9e7cb9b442becd6900f867e9e22be734254c13
1111
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
1212
1313
.. |badge1| image:: https://img.shields.io/badge/maturity-Mature-brightgreen.png
@@ -43,6 +43,11 @@ The **l10n_fr** module from the official addons adds a *SIRET* field on partners
4343
.. contents::
4444
:local:
4545

46+
Installation
47+
============
48+
49+
It's recommended to install ``python-stdnum>=1.18`` for SIRET support.
50+
4651
Usage
4752
=====
4853

‎l10n_fr_siret/__manifest__.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"website": "https://github.com/OCA/l10n-france",
1313
"license": "AGPL-3",
1414
"depends": ["l10n_fr", "base_view_inheritance_extension"],
15-
"external_dependencies": {"python": ["python-stdnum>=1.18"]},
15+
"external_dependencies": {"python": ["python-stdnum"]},
1616
"data": [
1717
"views/res_partner.xml",
1818
"views/res_company.xml",

‎l10n_fr_siret/readme/INSTALL.rst‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
It's recommended to install ``python-stdnum>=1.18`` for SIRET support.

‎l10n_fr_siret/static/description/index.html‎

Lines changed: 25 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,11 @@
88

99
/*
1010
:Author: David Goodger (goodger@python.org)
11-
:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
11+
:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
1212
:Copyright: This stylesheet has been placed in the public domain.
1313
1414
Default cascading style sheet for the HTML output of Docutils.
15+
Despite the name, some widely supported CSS2 features are used.
1516
1617
See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
1718
customize this style sheet.
@@ -274,7 +275,7 @@
274275
margin-left: 2em ;
275276
margin-right: 2em }
276277

277-
pre.code .ln { color: grey; } /* line numbers */
278+
pre.code .ln { color: gray; } /* line numbers */
278279
pre.code, code { background-color: #eeeeee }
279280
pre.code .comment, code .comment { color: #5C6576 }
280281
pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -300,7 +301,7 @@
300301
span.pre {
301302
white-space: pre }
302303

303-
span.problematic {
304+
span.problematic, pre.problematic {
304305
color: red }
305306

306307
span.section-subtitle {
@@ -366,7 +367,7 @@ <h1 class="title">French company identity numbers SIRET/SIREN/NIC</h1>
366367
!! This file is generated by oca-gen-addon-readme !!
367368
!! changes will be overwritten. !!
368369
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
369-
!! source digest: sha256:94ef8ef9d4aa0069dd19e158ac7f7c065ba1b283e8ea2b048363dac0c4a8166e
370+
!! source digest: sha256:ea67eff242155510a0475c4cde9e7cb9b442becd6900f867e9e22be734254c13
370371
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
371372
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Mature" src="https://img.shields.io/badge/maturity-Mature-brightgreen.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-france/tree/16.0/l10n_fr_siret"><img alt="OCA/l10n-france" src="https://img.shields.io/badge/github-OCA%2Fl10n--france-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-france-16-0/l10n-france-16-0-l10n_fr_siret"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-france&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
372373
<p>The <strong>l10n_fr</strong> module from the official addons adds a <em>SIRET</em> field on partners, but it doesn’t verify its validity. This module <strong>l10n_fr_siret</strong> adds several features:</p>
@@ -382,18 +383,23 @@ <h1 class="title">French company identity numbers SIRET/SIREN/NIC</h1>
382383
<p><strong>Table of contents</strong></p>
383384
<div class="contents local topic" id="contents">
384385
<ul class="simple">
385-
<li><a class="reference internal" href="#usage" id="toc-entry-1">Usage</a></li>
386-
<li><a class="reference internal" href="#bug-tracker" id="toc-entry-2">Bug Tracker</a></li>
387-
<li><a class="reference internal" href="#credits" id="toc-entry-3">Credits</a><ul>
388-
<li><a class="reference internal" href="#authors" id="toc-entry-4">Authors</a></li>
389-
<li><a class="reference internal" href="#contributors" id="toc-entry-5">Contributors</a></li>
390-
<li><a class="reference internal" href="#maintainers" id="toc-entry-6">Maintainers</a></li>
386+
<li><a class="reference internal" href="#installation" id="toc-entry-1">Installation</a></li>
387+
<li><a class="reference internal" href="#usage" id="toc-entry-2">Usage</a></li>
388+
<li><a class="reference internal" href="#bug-tracker" id="toc-entry-3">Bug Tracker</a></li>
389+
<li><a class="reference internal" href="#credits" id="toc-entry-4">Credits</a><ul>
390+
<li><a class="reference internal" href="#authors" id="toc-entry-5">Authors</a></li>
391+
<li><a class="reference internal" href="#contributors" id="toc-entry-6">Contributors</a></li>
392+
<li><a class="reference internal" href="#maintainers" id="toc-entry-7">Maintainers</a></li>
391393
</ul>
392394
</li>
393395
</ul>
394396
</div>
397+
<div class="section" id="installation">
398+
<h1><a class="toc-backref" href="#toc-entry-1">Installation</a></h1>
399+
<p>It’s recommended to install <tt class="docutils literal"><span class="pre">python-stdnum&gt;=1.18</span></tt> for SIRET support.</p>
400+
</div>
395401
<div class="section" id="usage">
396-
<h1><a class="toc-backref" href="#toc-entry-1">Usage</a></h1>
402+
<h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
397403
<p>On the Partner form, users will be able to enter:
398404
* the SIREN and NIC numbers: the SIRET number will be computed automatically.
399405
* the SIRET number: the SIREN and NIC will be computed automatically.</p>
@@ -404,33 +410,35 @@ <h1><a class="toc-backref" href="#toc-entry-1">Usage</a></h1>
404410
- if the partner is not attached to a specific company: is in any company or not attached to a specific company.</p>
405411
</div>
406412
<div class="section" id="bug-tracker">
407-
<h1><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h1>
413+
<h1><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h1>
408414
<p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/l10n-france/issues">GitHub Issues</a>.
409415
In case of trouble, please check there if your issue has already been reported.
410416
If you spotted it first, help us to smash it by providing a detailed and welcomed
411417
<a class="reference external" href="https://github.com/OCA/l10n-france/issues/new?body=module:%20l10n_fr_siret%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
412418
<p>Do not contact contributors directly about support or help with technical issues.</p>
413419
</div>
414420
<div class="section" id="credits">
415-
<h1><a class="toc-backref" href="#toc-entry-3">Credits</a></h1>
421+
<h1><a class="toc-backref" href="#toc-entry-4">Credits</a></h1>
416422
<div class="section" id="authors">
417-
<h2><a class="toc-backref" href="#toc-entry-4">Authors</a></h2>
423+
<h2><a class="toc-backref" href="#toc-entry-5">Authors</a></h2>
418424
<ul class="simple">
419425
<li>Numérigraphe</li>
420426
<li>Akretion</li>
421427
</ul>
422428
</div>
423429
<div class="section" id="contributors">
424-
<h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
430+
<h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
425431
<ul class="simple">
426432
<li>Lionel Sausin (Numérigraphe) &lt;<a class="reference external" href="mailto:ls&#64;numerigraphe.com">ls&#64;numerigraphe.com</a>&gt;</li>
427433
<li>Alexis de Lattre &lt;<a class="reference external" href="mailto:alexis.delattre&#64;akretion.com">alexis.delattre&#64;akretion.com</a>&gt;</li>
428434
</ul>
429435
</div>
430436
<div class="section" id="maintainers">
431-
<h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
437+
<h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
432438
<p>This module is maintained by the OCA.</p>
433-
<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
439+
<a class="reference external image-reference" href="https://odoo-community.org">
440+
<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
441+
</a>
434442
<p>OCA, or the Odoo Community Association, is a nonprofit organization whose
435443
mission is to support the collaborative development of Odoo features and
436444
promote its widespread use.</p>

‎l10n_fr_siret_lookup/README.rst‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ SIRET Lookup
77
!! This file is generated by oca-gen-addon-readme !!
88
!! changes will be overwritten. !!
99
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
10-
!! source digest: sha256:03fba67efc8266229377bb6b509fc696ca15a5c46eef0db0a8d749d51c7d7cdd
10+
!! source digest: sha256:ac452255edc06fcf3217f59520707f90747aa0c82f8f5b4d4bf2fddc31fc1dfb
1111
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
1212
1313
.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
@@ -51,6 +51,11 @@ In the 2 scenarios, it will update the following fields:
5151
.. contents::
5252
:local:
5353

54+
Installation
55+
============
56+
57+
It's recommended to install ``python-stdnum>=1.18`` for SIRET support.
58+
5459
Usage
5560
=====
5661

‎l10n_fr_siret_lookup/__manifest__.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"depends": [
1515
"l10n_fr_siret",
1616
],
17-
"external_dependencies": {"python": ["requests", "python-stdnum>=1.18"]},
17+
"external_dependencies": {"python": ["requests", "python-stdnum"]},
1818
"data": [
1919
"wizard/fr_siret_lookup_view.xml",
2020
"views/res_partner.xml",

‎l10n_fr_siret_lookup/readme/INSTALL.rst‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
It's recommended to install ``python-stdnum>=1.18`` for SIRET support.

‎l10n_fr_siret_lookup/static/description/index.html‎

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ <h1 class="title">SIRET Lookup</h1>
367367
!! This file is generated by oca-gen-addon-readme !!
368368
!! changes will be overwritten. !!
369369
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
370-
!! source digest: sha256:03fba67efc8266229377bb6b509fc696ca15a5c46eef0db0a8d749d51c7d7cdd
370+
!! source digest: sha256:ac452255edc06fcf3217f59520707f90747aa0c82f8f5b4d4bf2fddc31fc1dfb
371371
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
372372
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-france/tree/16.0/l10n_fr_siret_lookup"><img alt="OCA/l10n-france" src="https://img.shields.io/badge/github-OCA%2Fl10n--france-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-france-16-0/l10n-france-16-0-l10n_fr_siret_lookup"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-france&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
373373
<p>This modules updates partner fields via the <cite>SIRENE database &lt;https://data.opendatasoft.com&gt;</cite>. It uses the dataset <em>economicref-france-sirene-v3</em> of <cite>opendatasoft &lt;https://public.opendatasoft.com/explore/dataset/economicref-france-sirene-v3/information/&gt;</cite>. It computes a theorical VAT number from the SIREN and then checks the validity of the VAT number on <a class="reference external" href="https://ec.europa.eu/taxation_customs/vies/">VIES</a> (if invalid, the VAT number is discarded).</p>
@@ -390,57 +390,62 @@ <h1 class="title">SIRET Lookup</h1>
390390
<p><strong>Table of contents</strong></p>
391391
<div class="contents local topic" id="contents">
392392
<ul class="simple">
393-
<li><a class="reference internal" href="#usage" id="toc-entry-1">Usage</a></li>
394-
<li><a class="reference internal" href="#bug-tracker" id="toc-entry-2">Bug Tracker</a></li>
395-
<li><a class="reference internal" href="#credits" id="toc-entry-3">Credits</a><ul>
396-
<li><a class="reference internal" href="#authors" id="toc-entry-4">Authors</a></li>
397-
<li><a class="reference internal" href="#contributors" id="toc-entry-5">Contributors</a></li>
398-
<li><a class="reference internal" href="#other-credits" id="toc-entry-6">Other credits</a></li>
399-
<li><a class="reference internal" href="#maintainers" id="toc-entry-7">Maintainers</a></li>
393+
<li><a class="reference internal" href="#installation" id="toc-entry-1">Installation</a></li>
394+
<li><a class="reference internal" href="#usage" id="toc-entry-2">Usage</a></li>
395+
<li><a class="reference internal" href="#bug-tracker" id="toc-entry-3">Bug Tracker</a></li>
396+
<li><a class="reference internal" href="#credits" id="toc-entry-4">Credits</a><ul>
397+
<li><a class="reference internal" href="#authors" id="toc-entry-5">Authors</a></li>
398+
<li><a class="reference internal" href="#contributors" id="toc-entry-6">Contributors</a></li>
399+
<li><a class="reference internal" href="#other-credits" id="toc-entry-7">Other credits</a></li>
400+
<li><a class="reference internal" href="#maintainers" id="toc-entry-8">Maintainers</a></li>
400401
</ul>
401402
</li>
402403
</ul>
403404
</div>
405+
<div class="section" id="installation">
406+
<h1><a class="toc-backref" href="#toc-entry-1">Installation</a></h1>
407+
<p>It’s recommended to install <tt class="docutils literal"><span class="pre">python-stdnum&gt;=1.18</span></tt> for SIRET support.</p>
408+
</div>
404409
<div class="section" id="usage">
405-
<h1><a class="toc-backref" href="#toc-entry-1">Usage</a></h1>
410+
<h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
406411
<p>To update an existing parter, go to the partner form view and click on <em>Action &gt; SIREN Lookup</em>.</p>
407412
<p>By default, the search field is filled with Company name. To get more accurate results, you may want to add the City name where the company is registered. Then click on <em>Lookup</em>.</p>
408413
<p>A list of company is displayed. You may want to click on one in order to see corresponding information or directly selecting company from tree view. Once a company is selected, the partner information is updated and a message is logged in the chatter.</p>
409414
</div>
410415
<div class="section" id="bug-tracker">
411-
<h1><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h1>
416+
<h1><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h1>
412417
<p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/l10n-france/issues">GitHub Issues</a>.
413418
In case of trouble, please check there if your issue has already been reported.
414419
If you spotted it first, help us to smash it by providing a detailed and welcomed
415420
<a class="reference external" href="https://github.com/OCA/l10n-france/issues/new?body=module:%20l10n_fr_siret_lookup%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
416421
<p>Do not contact contributors directly about support or help with technical issues.</p>
417422
</div>
418423
<div class="section" id="credits">
419-
<h1><a class="toc-backref" href="#toc-entry-3">Credits</a></h1>
424+
<h1><a class="toc-backref" href="#toc-entry-4">Credits</a></h1>
420425
<div class="section" id="authors">
421-
<h2><a class="toc-backref" href="#toc-entry-4">Authors</a></h2>
426+
<h2><a class="toc-backref" href="#toc-entry-5">Authors</a></h2>
422427
<ul class="simple">
423428
<li>Le Filament</li>
424429
<li>Akretion</li>
425430
</ul>
426431
</div>
427432
<div class="section" id="contributors">
428-
<h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
433+
<h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
429434
<ul class="simple">
430435
<li>Benjamin Rivier &lt;benjamin-filament&gt; (<a class="reference external" href="https://le-filament.com">https://le-filament.com</a>)</li>
431436
<li>Remi Cazenave &lt;remi-filament&gt; (<a class="reference external" href="https://le-filament.com">https://le-filament.com</a>)</li>
432437
<li>Alexis de Lattre &lt;<a class="reference external" href="mailto:alexis.delattre&#64;akretion.com">alexis.delattre&#64;akretion.com</a>&gt;</li>
433438
</ul>
434439
</div>
435440
<div class="section" id="other-credits">
436-
<h2><a class="toc-backref" href="#toc-entry-6">Other credits</a></h2>
441+
<h2><a class="toc-backref" href="#toc-entry-7">Other credits</a></h2>
437442
<p>The development of this module has been financially supported by:</p>
438443
<ul class="simple">
439444
<li>Le Filament</li>
440445
</ul>
441446
</div>
442447
<div class="section" id="maintainers">
443-
<h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
448+
<h2><a class="toc-backref" href="#toc-entry-8">Maintainers</a></h2>
444449
<p>This module is maintained by the OCA.</p>
445450
<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
446451
<p>OCA, or the Odoo Community Association, is a nonprofit organization whose

‎requirements.txt‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
pyfrdas2>=0.4
33
pypdf>=3.1.0
44
python-stdnum
5-
python-stdnum>=1.18
65
requests
76
requests_oauthlib
87
unidecode

0 commit comments

Comments
 (0)