-
-
Notifications
You must be signed in to change notification settings - Fork 529
Switch resource_preview to resource_view #15902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I believe the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRs should never modify lexicon files other than the ones in en.
I don't think the language files should be touched at all. Just modify the en/ source. |
Why should we keep unused lexicons? By the way, there are so maaany of them, in fact. |
No one is suggesting keeping unused lexicons. CrowdIn will modify them based on changes to the source (i.e. the en lexicon is the source). |
Sorry for the delay, I'll get this updated tonight/tomorrow. Thanks! |
Setting this to rc2 so there's time for translations to catch up before the release. |
What does it do?
Changes the lexicon key from
resource_preview
toresource_view
, and the English words Preview to View.This is used in the context menu of the resource tree.
Why is it needed?
Adds uniformity to action names. The button
View
on the resource action bar does the same thing but they're named differently.The term preview may also make a user think they can see changes without saving.
How to test
Right click on a resource in the tree, or look in recent resources at ?a=security/profile
Related issue(s)/PR(s)
I remember this being mentioned before but if there's an issue I've missed it.