Skip to content

Adjust modUserGroup #15968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2022
Merged

Adjust modUserGroup #15968

merged 3 commits into from
Feb 2, 2022

Conversation

theboxer
Copy link
Member

What does it do?

  • Changes Children to composite relation (deleting modUserGroup will also delete all it's children)
  • Adjust the confirm message on resource group remove - to include notice about deleting children
  • Fix creating empty user group when dropping Anonymous user group under some other group
  • Disable D&D for admin and anonym user group
  • Disable changing parent of admin user group
  • Improve D&D of user groups (before you couldn't drop to user group without childs)
  • Remove sorting users from the processor - users are no longer part of the user groups tree

Why is it needed?

Overall QoL improvements and fixes.

How to test

Play with user groups

Related issue(s)/PR(s)

Resolves #15365

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Jan 13, 2022
@Ibochkarev Ibochkarev added this to the v3.0.0-rc1 milestone Jan 17, 2022
@Ibochkarev Ibochkarev added the pr/review-needed Pull request requires review and testing. label Jan 17, 2022
@opengeek opengeek modified the milestones: v3.0.0-rc1, v3.0.0-rc2 Jan 20, 2022
@opengeek opengeek merged commit eb50704 into modxcms:3.x Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaLuckers JoshuaLuckers JoshuaLuckers approved these changes

@Mark-H Mark-H Awaiting requested review from Mark-H Mark-H is a code owner

@opengeek opengeek Awaiting requested review from opengeek opengeek is a code owner

Assignees
No one assigned
Labels
cla-signed CLA confirmed for contributors to this PR. pr/review-needed Pull request requires review and testing.
Projects
None yet
Milestone
v3.0.0-rc2
Development

Successfully merging this pull request may close these issues.
4 participants
@theboxer @JoshuaLuckers @opengeek @Ibochkarev