Improve stripmodxtags output filter #15975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaLuckers
approved these changes
Jan 22, 2022
opengeek
approved these changes
Jan 28, 2022
opengeek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Improve the stripmodxtags regular expression
Why is it needed?
The previous string was using double quotes. Because of this the backslashes inside have to be escaped and the regular expression was not directly readable. The closing square brackets don't have to be escaped with backslashes (redundant character escape according to PhpStorm).
How to test
See this example: https://regex101.com/r/Tx8abk/1
Related issue(s)/PR(s)
3.x port of #15963