Skip to content

[3.x] Update permissions for viewing and clearing manager actions log #15981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 28, 2022

Conversation

muzzwood
Copy link
Contributor

@muzzwood muzzwood commented Jan 20, 2022

What does it do?

  • Removes the non-specific logs permission
  • Adds mgr_log_view permission
  • Adds mgr_log_erase permission
  • Includes these two new permissions in the Administrator and Developer policies.

I went with these names rather than the ones suggested in the issue so that they are uniform with the error log permissions.

Why is it needed?

This will allow a user to view the manager actions log but not clear it.

How to test

  1. Re-run setup to get the new permissions installed
  2. Log in with users with different access to attempt viewing and clearing the manager access log.

Related issue(s)/PR(s)

Closes #15739

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Jan 20, 2022
@muzzwood muzzwood changed the title Modify/add permissions for viewing/clearing manager action log. [3.x] Update permissions for viewing and clearing manager actions log Jan 20, 2022
@Mark-H Mark-H added this to the v3.1.0 milestone Jan 20, 2022
@JoshuaLuckers
Copy link
Contributor

Do we need to remove the logs permission in an upgrade script?

@muzzwood
Copy link
Contributor Author

Thanks @JoshuaLuckers - done!

@opengeek
Copy link
Member

Hmm. Does this really need to be held until 3.1? If so, then the upgrade script needs to be targeted at 3.1 instead of 3.0.

@Mark-H
Copy link
Collaborator

Mark-H commented Jan 26, 2022

Felt more like a feature than a fix, but I'm certainly more than happy to see it in rc2 as well.

@opengeek
Copy link
Member

Since I don't believe this would affect any extras, I think it makes more sense to just bring it in for RC2 if no one else has objections.

@opengeek opengeek modified the milestones: v3.1.0, v3.0.0-rc2 Jan 26, 2022
@muzzwood
Copy link
Contributor Author

Fine with me! :)

@opengeek opengeek merged commit 3427149 into modxcms:3.x Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for contributors to this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants