-
-
Notifications
You must be signed in to change notification settings - Fork 529
Changed the minimum width of popup window #15984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do you have a reproducible click path where this issue occurs? Then I can look for this. Does the alert has an explicit ID? |
@Jako This happens in the Deleted Resources Manager, see more details #14340
This happens, at least, by clicking on the "Erase All", "Restore All" button (most likely relevant for all windows). And you can click one, close it, and click another - the effect will repeat. |
This is not a real fix, because it does not solve but just bypass the issue. |
Yes, that's what I meant by:
And added the "proposal" tag. |
Please use #15996 and set the minWidth of the confirm boxes by option.
|
@Jako Are you sure it works? |
Yes it is working here fine. You have to add the minWidth to all MODx.msg.confirm calls in modx.grid.trash.js (6 times). |
And maybe you have to force reload the manager to load the changed javascripts. |
Yes, thanks, it works, I will correct this PR after your PR #15996 merges. |
@Jako please check. |
What does it do?
For some reason the width of popups is sometimes reset to the minimum width.
Previously, the value was equal to 200px, which is not enough, increased to 400px, so that even when resetting the content is not cut off.Set window width via parameter - #15984 (comment)
Before (content can be cut off by window):

After:

Why is it needed?
Prevent cut off of window content.
Related issue(s)/PR(s)
#14340