Fix aliases for resource controllers #15997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theboxer
added
the
bug
JoshuaLuckers
approved these changes
Jan 25, 2022
Ibochkarev
approved these changes
Jan 25, 2022
JoshuaLuckers
added
the
pr/ready-for-merging
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes class aliases for resource controllers introduced in #15888
Why is it needed?
Create resource pages don't work, when you pass the class key, for example:
/manager/?a=resource/create&parent=1&context_key=web&class_key=MODX\Revolution\modDocumentwill throwError: Class 'DocumentCreateManagerController' not foundThe class alias is defined before the class itself, which is probably invalid :)
How to test
Open
/manager/?a=resource/create&parent=1&context_key=web&class_key=MODX\Revolution\modDocumentwith and without this fix.