[3.x] Remove unnecessary uses of deprecated strftime() #15999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ibochkarev
approved these changes
Jan 25, 2022
theboxer
requested changes
Jan 25, 2022
core/src/Revolution/Processors/Resource/Event/UpdateFromGrid.php
Outdated
Show resolved
Hide resolved
core/src/Revolution/Processors/Resource/Event/UpdateFromGrid.php
Outdated
Show resolved
Hide resolved
JoshuaLuckers
force-pushed
the
replace-strftime
branch
from
a7b6159 to
32f6ff6
Compare
JoshuaLuckers
force-pushed
the
replace-strftime
branch
from
32f6ff6 to
fc83e55
Compare
theboxer
approved these changes
Jan 25, 2022
|
@theboxer thank you! |
|
Why is the time format different in some files? Maybe it's worth bringing to the same format (where it possible)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Replace the function
strftimewithdatewhere possible.If the
formatparamater comes from a variable thestrftimefunction is not replaced since this means a breaking change.Why is it needed?
In PHP 8.1 the function
strftimeis deprecated.How to test
Use PHP 8.1 and see a lot less deprecation warnings.
Related issue(s)/PR(s)
Resolves #15988
Related to #15864