[3.x] Fix issue where moving resource above another would make the "target" a container. #16001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruslan-Aleev
approved these changes
Jan 28, 2022
Mark-H
reviewed
Feb 2, 2022
Mark-H
reviewed
Feb 2, 2022
|
Made two minor code suggestions to make sure the validation actually does something, but I can confirm this resolves the issue with random assignments. |
Co-authored-by: Mark Hamstra <[email protected]>
opengeek
approved these changes
Feb 2, 2022
|
I think a botched trying to add brevity to the title of this merged change. It would be helpful if we can more concisely describe changes like this when submitting. I know it's not easy sometimes. |
What would have been a better title? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Make sure we only mark the target as folder when the node is appended to another node.
If the point we are dragging/dropping the node is "above/below", the target resource is a sibling and not a parent and therefore it should not become a container/folder.
Why is it needed?
Fix issue where moving resource above another would make the "target" a container.
How to test
Drag and drop a resource above another resource that's not a container/folder.
Also see #15991
Related issue(s)/PR(s)
Resolves #15991